> On Nov. 2, 2017, 1:34 a.m., Sergey Shelukhin wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2475 (patched) > > <https://reviews.apache.org/r/63458/diff/1/?file=1877741#file1877741line2475> > > > > hmm... would it make sense to have 3 limits instead? per user, per ip, > > and per user+ip (if needed). All would be enforced. Or is it going to be > > extensible?
Yeah. Makes sense to have 3 limits. Updated patch. All 3 are tracked now. > On Nov. 2, 2017, 1:34 a.m., Sergey Shelukhin wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > > Lines 472 (patched) > > <https://reviews.apache.org/r/63458/diff/1/?file=1877742#file1877742line472> > > > > nit: map is concurrent, it should be possible to use putIfAbsent and > > replace w/o synchronize update with java 8 one liner. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/#review189860 ----------------------------------------------------------- On Nov. 1, 2017, 2:04 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63458/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2017, 2:04 a.m.) > > > Review request for hive, Sergey Shelukhin and Thejas Nair. > > > Bugs: HIVE-16917 > https://issues.apache.org/jira/browse/HIVE-16917 > > > Repository: hive-git > > > Description > ------- > > HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > a3c853a5c5a2a3e72ae0141d0ad836ec95516280 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 9b2ae57ee498e9b712cc87b16ba223995519611c > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 6354c8c5450eaa8ab91dd59387f2eddf0eb84389 > > service/src/test/org/apache/hive/service/cli/TestCLIServiceConnectionLimits.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63458/diff/1/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
