> On Dec. 11, 2017, 10:27 p.m., Ashutosh Chauhan wrote: > > accumulo-handler/src/test/results/positive/accumulo_queries.q.out > > Line 292 (original), 292 (patched) > > <https://reviews.apache.org/r/64510/diff/1/?file=1912710#file1912710line292> > > > > Regression?
In fact it is an improvement _key > 100 and key < 120_. It gets the _key > 100_ from the other branch. > On Dec. 11, 2017, 10:27 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/explainuser_1.q.out > > Line 450 (original), 450 (patched) > > <https://reviews.apache.org/r/64510/diff/1/?file=1912725#file1912725line450> > > > > Is this predicate simplification correct? The original condition is: ((col3 > 0) or (col1 >= 0)) and ((col1 >= 1) or (col4 >= 1)) >From below, we have that col1 i.e. c_int, is col1 > 0. Thus, _((col3 > 0) or >(col1 >= 0))_ folds to _true_. Hence, we keep only _((col1 >= 1) or (col4 >= >1))_. > On Dec. 11, 2017, 10:27 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/masking_10.q.out > > Line 122 (original) > > <https://reviews.apache.org/r/64510/diff/1/?file=1912726#file1912726line122> > > > > Seems like this predicate folded to false. But that seems incorrect. _alias01.key = alias02.a_ where _a=2017_ (in join condition) _ and ((alias01.key % 2) = 0) and (alias01.key < 10)_ (coming from left input) fold to _false_ on the right input for the left outer join (observe that it does not propagate to left input, since it is a left outer join). > On Dec. 11, 2017, 10:27 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/ppd_gby_join.q.out > > Line 70 (original) > > <https://reviews.apache.org/r/64510/diff/1/?file=1912733#file1912733line70> > > > > Does this predicate folded to true. That doesn't look correct. _key < '400' and (key < '50' or key > '50')_ -> _(key < '400' or key < '50') and (key < '400' or key > '50')_ -> _key < '400' and (key < '400' or key > '50')_ -> _key < '400'_ (note it is lexicographic comparison). > On Dec. 11, 2017, 10:27 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/ppd_join5.q.out > > Line 180 (original), 180 (patched) > > <https://reviews.apache.org/r/64510/diff/1/?file=1912735#file1912735line180> > > > > Does this predicate got simplified to false? _id1 <= 1_ is specified below and the condition above is _id1 > 1_. Hence it folds to _false_. > On Dec. 11, 2017, 10:27 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/ppd_join5.q.out > > Line 194 (original), 194 (patched) > > <https://reviews.apache.org/r/64510/diff/1/?file=1912735#file1912735line194> > > > > Does this predicate got simplified to false? _d <= 1_ is specified below and the condition above is _d > 1_. Hence it folds to _false_. > On Dec. 11, 2017, 10:27 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/ppd_join5.q.out > > Line 256 (original) > > <https://reviews.apache.org/r/64510/diff/1/?file=1912735#file1912735line256> > > > > Does this predicate got simplified to false? _d <= 1_ is specified below and the condition above is _d > 1_. Hence it folds to _false_. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64510/#review193459 ----------------------------------------------------------- On Dec. 11, 2017, 9:45 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64510/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2017, 9:45 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-18068 > https://issues.apache.org/jira/browse/HIVE-18068 > > > Repository: hive-git > > > Description > ------- > > HIVE-18068 > > > Diffs > ----- > > accumulo-handler/src/test/results/positive/accumulo_queries.q.out > bd79eefb87b19ab6409238305a0256cf17af06cf > hbase-handler/src/test/results/positive/hbase_queries.q.out > d6ec14e3759958d7e41dfa813fe239aaa860885d > pom.xml a6b5663b7677c9d3d088a1d563e6c3b78199ba02 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java > 77a7b0f26bd21f5e36a2814a929513b3bdc6c9ce > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelDistribution.java > 653f1c535c2789e337c95d26bc6d3b2d5657d5c0 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateProjectMergeRule.java > b5f17754cb43bdc8fabb20ee77279bad50fd2061 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregatePullUpConstantsRule.java > 370c0eca47b335aed9934dea5b50d519dd22ff57 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java > 9a5d8e2826f309ac274976f5ffbf374901c5b16b > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > ba64f97105eaaa0a5d3f2ad1883db42608c95ae8 > ql/src/test/results/clientpositive/druid/druidmini_test1.q.out > 9577e72ee4a4eee4cbf62aba7689127ee7491e2a > ql/src/test/results/clientpositive/druid_basic2.q.out > 5a5f7541ecd7b131f424a94e1bcc9a572d880bff > ql/src/test/results/clientpositive/druid_basic3.q.out > c174a5cc54429857dcba3af7f7027c7e94843200 > ql/src/test/results/clientpositive/druid_intervals.q.out > 3cd28b513136c667e62f734741a1db65e43ff62d > ql/src/test/results/clientpositive/druid_timeseries.q.out > 330c068a02cafb9935a2e02a544702fedf8dece8 > ql/src/test/results/clientpositive/druid_topn.q.out > 3e2b477dfc7e515a715882a8f9f7d999951de1e0 > ql/src/test/results/clientpositive/llap/explainuser_1.q.out > 5adf401b25fcc1e548aed510d73177f9df62bc50 > ql/src/test/results/clientpositive/masking_10.q.out > e1a398af99120d2e17d5b126e8a78a28ed42d775 > ql/src/test/results/clientpositive/perf/spark/query11.q.out > 17b2309379e3511d5712ad5608bedba18974d48b > ql/src/test/results/clientpositive/perf/spark/query4.q.out > 71154ff8a76b8a717d996708456f2d809511d7df > ql/src/test/results/clientpositive/perf/spark/query74.q.out > 497e792bc2c8608618aadffc8955c9eb4fdf2f5f > ql/src/test/results/clientpositive/perf/tez/query11.q.out > 69ced2611c7ff13e2247b0d38e4d109903de80a8 > ql/src/test/results/clientpositive/perf/tez/query4.q.out > 81867b967551dea1269461d55407e3c18cd8e29e > ql/src/test/results/clientpositive/perf/tez/query74.q.out > a75aaa129441c4a87b60e5db34bc4f6e7fd3010e > ql/src/test/results/clientpositive/ppd_gby_join.q.out > 75d0a6270da36c91409b7948b01f0af47bf1a48a > ql/src/test/results/clientpositive/ppd_join.q.out > 02aa5c2670056f5e26ef13705d702bd4857d6b65 > ql/src/test/results/clientpositive/ppd_join5.q.out > ca17699ca39bbfe0901e99c2e6d588d1f3eec4d3 > ql/src/test/results/clientpositive/spark/ppd_gby_join.q.out > 1dc1a2594f4f6d805fcd282e1d4e94ea29228138 > ql/src/test/results/clientpositive/spark/ppd_join.q.out > dd2c394d48c398c9b3de35aa42877670eeb13daf > ql/src/test/results/clientpositive/spark/ppd_join5.q.out > 41817d8087e66a0912288c971cb2b7bce5875d0d > ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out > 6a4bea1bd4e4ae60c014469206de35ac56001508 > > > Diff: https://reviews.apache.org/r/64510/diff/1/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
