----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64925/#review194722 -----------------------------------------------------------
I think it is better to separate changes to BoneCP/Hikari configs from changes to HiveMetastore into separate JIRAs since they deal with completely different issues so bundling them together doesn't help. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 884 (patched) <https://reviews.apache.org/r/64925/#comment273657> Is it ok to leak table name names in the log? standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 885 (patched) <https://reviews.apache.org/r/64925/#comment273656> Can context.getException() be null here? standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1635 (patched) <https://reviews.apache.org/r/64925/#comment273658> How can this ever happen? The only way to fail is to throw exception, so this isn't going to be executed ever. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1670 (patched) <https://reviews.apache.org/r/64925/#comment273659> Same here. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1718 (patched) <https://reviews.apache.org/r/64925/#comment273660> Same here standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1773 (patched) <https://reviews.apache.org/r/64925/#comment273661> Same here standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1828 (patched) <https://reviews.apache.org/r/64925/#comment273662> Same here standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1883 (patched) <https://reviews.apache.org/r/64925/#comment273663> Same here standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1938 (patched) <https://reviews.apache.org/r/64925/#comment273664> Same here standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Line 2178 (original), 2203 (patched) <https://reviews.apache.org/r/64925/#comment273665> Same here - Alexander Kolbasov On Jan. 3, 2018, 8:09 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64925/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 8:09 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-18349 > https://issues.apache.org/jira/browse/HIVE-18349 > > > Repository: hive-git > > > Description > ------- > > HIVE-18349: Misc metastore changes for debuggability > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > f1b58c526db15cfdf9098af603549643c0f4dd13 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 2e43dc85eae2490683a52444c9456e201697a3b3 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > 4ff2bb77d387bd2182f8cdd248303edd15dd12bd > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java > 6ffc24a27a452f9a063831a2a1d39a7b1be5d6b5 > > > Diff: https://reviews.apache.org/r/64925/diff/1/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
