> On Jan. 3, 2018, 10:14 p.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 884 (patched) > > <https://reviews.apache.org/r/64925/diff/1/?file=1929986#file1929986line884> > > > > Is it ok to leak table name names in the log?
Table names are not sensitive info. > On Jan. 3, 2018, 10:14 p.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 1670 (patched) > > <https://reviews.apache.org/r/64925/diff/1/?file=1929986#file1929986line1670> > > > > Same here. This is different case. If commit transaction fails the failure is not captured in logs. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64925/#review194722 ----------------------------------------------------------- On Jan. 4, 2018, 9:10 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64925/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 9:10 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-18349 > https://issues.apache.org/jira/browse/HIVE-18349 > > > Repository: hive-git > > > Description > ------- > > HIVE-18349: Misc metastore changes for debuggability > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java > 1ca18b9 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > f1b58c5 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreEndFunctionContext.java > 998531f > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 2e43dc8 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > 4ff2bb7 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java > 6ffc24a > > > Diff: https://reviews.apache.org/r/64925/diff/2/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
