----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65185/#review195530 -----------------------------------------------------------
Minor issues, code is fine. ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java Line 509 (original), 507 (patched) <https://reviews.apache.org/r/65185/#comment274735> Earlier code was flat pools array. This gets called in 2 contexts now, both rp and pools. It will work for pool under root. But will not work for children of pool. We should start another pools/children array inside this. There is a test case TestJsonRPFormatter, which should be updated for this. ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java Line 771 (original), 797 (patched) <https://reviews.apache.org/r/65185/#comment274734> if p1.pool == null && p2.pool == null then it should return 0; ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java Lines 883 (patched) <https://reviews.apache.org/r/65185/#comment274736> Because of foreign key constraints unusedTriggers and unusedMappings should not happen. - Harish Jaiprakash On Jan. 17, 2018, 7:45 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65185/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2018, 7:45 a.m.) > > > Review request for hive, Harish Jaiprakash and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > 8f28b62311 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > 035c5fcc91 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > 489842ee82 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > 0f1e893de6 > ql/src/test/queries/clientpositive/resourceplan.q b46c1ee2d6 > ql/src/test/results/clientpositive/llap/resourceplan.q.out 72a78b1b4a > > > Diff: https://reviews.apache.org/r/65185/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
