> On Jan. 17, 2018, 11:27 a.m., Harish Jaiprakash wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > > Lines 883 (patched) > > <https://reviews.apache.org/r/65185/diff/1/?file=1940765#file1940765line884> > > > > Because of foreign key constraints unusedTriggers and unusedMappings > > should not happen. > > Sergey Shelukhin wrote: > Unused trigger is simply a trigger not attached to any pool, so it's > possible (see the q.out output) > I am not sure what to do with invalid mappings; I was going to throw an > error but that's not super helpful. If they are impossible on DB level, they > simply won't be output... do you think this code should be removed.
No, just wanted to understand. I was thinking I should add this check to validation code. And raise warnings. - Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65185/#review195530 ----------------------------------------------------------- On Jan. 18, 2018, 2:04 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65185/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 2:04 a.m.) > > > Review request for hive, Harish Jaiprakash and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > 8f28b62311 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > 035c5fcc91 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > 489842ee82 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > 0f1e893de6 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/formatting/TestJsonRPFormatter.java > f2b689098d > ql/src/test/queries/clientpositive/resourceplan.q b46c1ee2d6 > ql/src/test/results/clientpositive/llap/resourceplan.q.out 72a78b1b4a > > > Diff: https://reviews.apache.org/r/65185/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
