> On Jan. 22, 2018, 2:21 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > > Lines 218 (patched) > > <https://reviews.apache.org/r/65241/diff/1/?file=1942599#file1942599line218> > > > > Is this ok to have this characters in the index name?
Currently it is allowed to add, get and drop indexes with names like this. But for table names, special characters are not allowed, so we should consider restricting the index names like this. I will add a TODO and fix this issue in a separate Jira. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195904 ----------------------------------------------------------- On Jan. 19, 2018, 3:17 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65241/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 3:17 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18496 > https://issues.apache.org/jira/browse/HIVE-18496 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - void createIndex(Index, Table) > - boolean dropIndex(String, String, String, boolean) > - void alter_index(String, String, String, Index) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65241/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
