----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/ -----------------------------------------------------------
(Updated Jan. 23, 2018, 5:21 p.m.) Review request for hive, Peter Vary and Adam Szita. Changes ------- Addressed review findings. Bugs: HIVE-18496 https://issues.apache.org/jira/browse/HIVE-18496 Repository: hive-git Description ------- The following methods of IMetaStoreClient are covered by this test. - void createIndex(Index, Table) - boolean dropIndex(String, String, String, boolean) - void alter_index(String, String, String, Index) The test covers not just the happy pathes, but the edge cases as well. Diffs (updated) ----- standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java PRE-CREATION Diff: https://reviews.apache.org/r/65241/diff/2/ Changes: https://reviews.apache.org/r/65241/diff/1-2/ Testing ------- Run the tests Thanks, Marta Kuczora