> On Feb. 16, 2018, 4:50 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > > Lines 139 (patched) > > <https://reviews.apache.org/r/65422/diff/1/?file=1950494#file1950494line140> > > > > Should also compare with parent to check rowcount and other stats are > > not greater than parent.
ok > On Feb. 16, 2018, 4:50 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > > Lines 310 (patched) > > <https://reviews.apache.org/r/65422/diff/1/?file=1950494#file1950494line311> > > > > Should also compare with parent to check rowcount and other stats are > > not greater than parent and normalize to parent stats in that case. ok - Zoltan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review197649 ----------------------------------------------------------- On Feb. 26, 2018, 6:19 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65422/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2018, 6:19 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > preview > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0880a960e6 > data/conf/llap/hive-site.xml c4c299c5de > itests/src/test/resources/testconfiguration.properties 2776fe95f1 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 6cd7a136ae > ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/Context.java dba2dbb15b > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 94999fed93 > ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java 60e8de8fd4 > ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java 2a32a51588 > ql/src/java/org/apache/hadoop/hive/ql/IDriver.java 9f13fa8e88 > ql/src/java/org/apache/hadoop/hive/ql/ReExecOverlayDriver.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/ReOptimizeDriver.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 32fc257b03 > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 199b181290 > ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java > 395a5f450f > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java > 8dd7cfe58c > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkEmptyKeyOperator.java > 134fc0ff0b > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkObjectHashOperator.java > 1eb72ce4d9 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkUniformHashOperator.java > 384bd74686 > ql/src/java/org/apache/hadoop/hive/ql/hooks/PrivateHookContext.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java > b0cf3bd94e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 783a672c47 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > 9a3f81c98f > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 78cbf25c43 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 733ec79ce1 > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java f9a6386ecf > ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 0057f0c2c6 > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/EmptyStatsSource.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/GroupTransformer.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapperProcess.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/RuntimeStatsSource.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/SimpleRuntimeStatsSource.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/StatsSource.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/refs/OperatorRef.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStats.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStatsReaderHook.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrueOOM.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java > fa3f89fda1 > ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestOperatorCmp.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestReOptimization.java > PRE-CREATION > ql/src/test/queries/clientpositive/retry_failure.q PRE-CREATION > ql/src/test/queries/clientpositive/retry_failure_oom.q PRE-CREATION > ql/src/test/queries/clientpositive/retry_failure_stat_changes.q > PRE-CREATION > ql/src/test/results/clientpositive/llap/dp_counter_mm.q.out 869916078b > ql/src/test/results/clientpositive/llap/dp_counter_non_mm.q.out 9f6426ccd1 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out > cab45c9410 > ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 > ql/src/test/results/clientpositive/llap/join32_lessSize.q.out 5b5be13702 > ql/src/test/results/clientpositive/llap/join46.q.out 4625b9fed8 > ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out > 4dd7432ac5 > ql/src/test/results/clientpositive/llap/llap_partitioned.q.out ac754674ea > ql/src/test/results/clientpositive/llap/mapjoin46.q.out f530c1e8e1 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out aa2dcc7f68 > ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out eb54a81d1a > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 590437c708 > ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out > c7c8993d0e > ql/src/test/results/clientpositive/llap/retry_failure.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/retry_failure_oom.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/retry_failure_stat_changes.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out cdfa73349b > ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a > ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f > ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 > ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 > ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 > ql/src/test/results/clientpositive/llap/tez_join_tests.q.out 75879fb157 > ql/src/test/results/clientpositive/llap/tez_joins_explain.q.out 3790b37760 > > ql/src/test/results/clientpositive/llap/vector_reduce_groupby_duplicate_cols.q.out > 07c1e4188c > ql/src/test/results/clientpositive/perf/tez/query72.q.out 55ddd5a0f8 > ql/src/test/results/clientpositive/perf/tez/query78.q.out 9c2d7b3491 > ql/src/test/results/clientpositive/show_functions.q.out 4e8ceaf6af > > > Diff: https://reviews.apache.org/r/65422/diff/3/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
