----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review198652 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/Driver.java Lines 653 (patched) <https://reviews.apache.org/r/65422/#comment278887> I meant this should be run only if first query execution failed. Also when it runs it should simultaneously collect stats from executed tree. Actually I am not sure how its computing even signatures, since its not passing any reference to plan itself. ql/src/java/org/apache/hadoop/hive/ql/optimizer/signature/OpSignature.java Lines 35 (patched) <https://reviews.apache.org/r/65422/#comment278888> Add comment about what is key and what is value. ql/src/java/org/apache/hadoop/hive/ql/optimizer/signature/OpTreeSignature.java Lines 68 (patched) <https://reviews.apache.org/r/65422/#comment278889> I think we agreed on that signature of operator is stored in a flat structure which can be compared without traversing full tree. Can you leave a TODO for this? ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java Lines 2506 (patched) <https://reviews.apache.org/r/65422/#comment278890> Whats the need for this condition? Runtime stats are always accurate even when state is determined as complete during compile time. - Ashutosh Chauhan On March 5, 2018, 8:08 a.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65422/ > ----------------------------------------------------------- > > (Updated March 5, 2018, 8:08 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-17626 > https://issues.apache.org/jira/browse/HIVE-17626 > > > Repository: hive-git > > > Description > ------- > > preview > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > eca35731292df6e1adef7ec04164e39a7baf13e1 > data/conf/llap/hive-site.xml cdda875ddbcc7b6fe977770523779487d30a043a > > druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidScanQueryRecordReader.java > PRE-CREATION > itests/src/test/resources/testconfiguration.properties > 32b75518cfea11367e0adee26b08c47887a59b54 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 2d0aca0a11bda6b9dce31ccf6acfcfd81e412d5a > itests/util/src/test/java/org/apache/hadoop/hive/ql/TestQTestUtil.java > c01d87bf51942f01a38e21ffbd66a9313a91e9a6 > ql/src/java/org/apache/hadoop/hive/ql/Context.java > dba2dbb15b6dadee4a5cd640c8cea39669869477 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > 2d7e4597de623d892702cae6e732ec5eb09d87da > ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java > 49d2bf5f335c6806460fb6b83ee4da8bf842bd5a > ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/IDriver.java > d4494cc72ed706886f829195a58514082793be4f > ql/src/java/org/apache/hadoop/hive/ql/cache/results/CacheUsage.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > 76e85636d1ecddc720d6b6e3680194354a6e157c > ql/src/java/org/apache/hadoop/hive/ql/exec/MaterializedViewDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/MaterializedViewTask.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java > 199b1812903a1cff9d3f52078eff92fc2aa3cec5 > ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java > 395a5f450f91151773edd49f42145209b8877cc8 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveInputCounters.java > 085d6a7d94ca40faed3ec87f95962cb7fd774100 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectSubCache.java > 0d31e6e42203b3a9146b678b1694c457dd56ab2a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java > 8dd7cfe58c467df479be0b5984fe2a9bf9f5ab7a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkEmptyKeyOperator.java > 134fc0ff0b1412ebb9783da3bf28a9c1b9f10dbc > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkObjectHashOperator.java > 1eb72ce4d981ae95f02d1d5acded1d8661272128 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkUniformHashOperator.java > 384bd746869540df35c235ab28a33d2625e9a8b5 > ql/src/java/org/apache/hadoop/hive/ql/hooks/PrivateHookContext.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java > b75850760f9cbe1ed969bd7ac53196dd49d081a3 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java > b0cf3bd94e1cbae2386cd2f475e47b44f750d088 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOpMaterializationValidator.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 190771ea6b1cbf4b669a8919271b25a689af941b > ql/src/java/org/apache/hadoop/hive/ql/optimizer/signature/OpSignature.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/signature/OpTreeSignature.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/signature/OpTreeSignatureFactory.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/signature/Signature.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/signature/SignatureUtils.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkPartitionPruningSinkDesc.java > d1c53cf34515d73f24425a7b3a6afdf2d076b9d4 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > cbadfa4f07e04f6575faa9147df687cb860cb5ca > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > 78cbf25c436e44258947c459e3e0c0e24eb9d622 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g > 907362312da329010dcde53d8fb6f5790f022fbd > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > 35f9edfecc74b85fe64a2cbe6290ca44a341c63e > ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java > 714cf3914b0190c360a1246934902db1c8ab4012 > ql/src/java/org/apache/hadoop/hive/ql/plan/AppMasterEventDesc.java > 7d5be6ba819fd73d1bded1a7a246049a0a2f420d > ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java > 7332693513fe4a9374422a7671e82351590988f2 > ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPruningEventDesc.java > 5d3fdb8b632c9bfd3ee40b0f6e30b71e5aa3cf46 > ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java > 92b8031da6d1157d8f979455f8a8a1556b1c5ccd > ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java > d59834ce08e802c4869a9aede5a957efb1358863 > ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java > e90a3987ec3ed3a60728120a0d3b624badbec922 > ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableSinkDesc.java > 9c651ab3abea1614d421acb44273717357eb8f0d > ql/src/java/org/apache/hadoop/hive/ql/plan/JoinCondDesc.java > 6dcf05af283cda23becb2ceaea6b466ace3e8b54 > ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java > bd45c752e1c19bd9c2bf30f760074d71ba5c6265 > ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java > 3837a4993494ec7c4bc96b966b740aed0a3d8482 > ql/src/java/org/apache/hadoop/hive/ql/plan/LimitDesc.java > ce53feae00930d3a39c3ebc14a2e4dfa592d404d > ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java > 23dd19bbaeb8b00a975e6b9b70eda1d91a697828 > ql/src/java/org/apache/hadoop/hive/ql/plan/OperatorDesc.java > 870b4d9a268c0b54006435b09e4e9a40ba41c59c > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java > bf24ff8f09f81a79ec3462f7641d4f8fb7159cd7 > ql/src/java/org/apache/hadoop/hive/ql/plan/ScriptDesc.java > 858de98229cf1884bd31bfaee67396bd32208418 > ql/src/java/org/apache/hadoop/hive/ql/plan/SelectDesc.java > e38e7e468fd6eaddfb5f5749b27dd44f8682f0f0 > ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java > 0057f0c2c6b607f8d6fef5e36fee9ab36a741718 > ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java > 661446df0b9fbb5cf248d76205e47dbaa113026f > ql/src/java/org/apache/hadoop/hive/ql/plan/UDTFDesc.java > cf8e6e547ed8bd39dd353a3f6fb075ad71faf55d > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/EmptyStatsSource.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/GroupTransformer.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapperProcess.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/RuntimeStatsSource.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/SimpleRuntimeStatsSource.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/StatsSource.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/reexec/IReExecutionPlugin.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecDriver.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecutionOverlayPlugin.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/reexec/ReOptimizePlugin.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStats.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStatsReaderHook.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrueOOM.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEnforceNotNullConstraint.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java > fa3f89fda152b3a0f3d47d4ec4bb9960e4447349 > > ql/src/test/org/apache/hadoop/hive/ql/optimizer/signature/TestOpSigFactory.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/optimizer/signature/TestOperatorSignature.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestOperatorCmp.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestReOptimization.java > PRE-CREATION > ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java > cc97317f55a0342a0d51dc938028b071306ddadd > ql/src/test/org/apache/hive/testutils/TestHiveTestEnvSetup.java > 91613667f876c3bd249e7230d2fbc0a33e354d26 > ql/src/test/org/apache/hive/testutils/TestX1.java PRE-CREATION > ql/src/test/queries/clientpositive/retry_failure.q PRE-CREATION > ql/src/test/queries/clientpositive/retry_failure_oom.q PRE-CREATION > ql/src/test/queries/clientpositive/retry_failure_stat_changes.q > PRE-CREATION > ql/src/test/results/clientpositive/llap/dp_counter_mm.q.out > 981f2607fb537b0754c4cfa7c7201b1985dd29af > ql/src/test/results/clientpositive/llap/dp_counter_non_mm.q.out > 9f6426ccd1d3430743d7816f65b51174ef61e2a8 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out > aa2dcc7f6852e2fe72e67a4cfe9688bae4291625 > ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out > eb54a81d1a8f769a48e95b54cd6ca7e698cf9963 > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out > c5302c347068eb7a64becfaeae769babda4e7615 > ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out > c7c8993d0e2f682a6442df574a291bd101356efb > ql/src/test/results/clientpositive/llap/retry_failure.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/retry_failure_oom.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/retry_failure_stat_changes.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/tez_input_counters.q.out > 71d14f404966b8971fba739ef4d9091e4140cea3 > ql/src/test/results/clientpositive/show_functions.q.out > 43e4a5de393d4b23c4c0257f08c32dd650eaaadc > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/hooks/URIResolverHook.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/messaging/CreateDatabaseMessage.java > 3d64c7341a17b0f7e7213cc1606adebc8874820a > > > Diff: https://reviews.apache.org/r/65422/diff/7/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
