> On March 29, 2018, 6:12 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 779 (patched) > > <https://reviews.apache.org/r/66349/diff/2/?file=1989894#file1989894line779> > > > > Can we refactor this so we call _isValueClause_ and _updating_ > > functions only once (trying to avoid some overhead)? > > Vineet Garg wrote: > I am not sure if I understand your comment. It'll be called only once > when doPhase1GetColumnAliasesFromSelect is called.
I meant below: these functions are called in L784 and L788 again, no need to traverse AST multiple times. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66349/#review200203 ----------------------------------------------------------- On March 30, 2018, 4:43 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66349/ > ----------------------------------------------------------- > > (Updated March 30, 2018, 4:43 a.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Bugs: HIVE-19059 > https://issues.apache.org/jira/browse/HIVE-19059 > > > Repository: hive-git > > > Description > ------- > > This patch adds support for specifying DEFAULT keyword with INSERT and UPDATE > e.g. > INSERT INTO T1 values(DEFAULT, DEFAULT..) > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties e188619a6d > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 26f20f2e05 > ql/src/test/queries/clientpositive/insert_into_default_keyword.q > PRE-CREATION > ql/src/test/results/clientpositive/llap/insert_into_default_keyword.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66349/diff/3/ > > > Testing > ------- > > Added more tests > Existing pcommit tests > > > Thanks, > > Vineet Garg > >
