> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > <https://reviews.apache.org/r/65985/diff/2/?file=1976883#file1976883line409> > > > > why do we need !success check here? > > Sergio Pena wrote: > Ah? Thanks, I missed this. I removed the first condition and leave this > one instead.
I thought we need the first condition and not the second condition for !success. Are we not generating the events only when the transaction is successful? Am I missing something? - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review200405 ----------------------------------------------------------- On April 4, 2018, 4:06 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65985/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 4:06 p.m.) > > > Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18783 > https://issues.apache.org/jira/browse/HIVE-18783 > > > Repository: hive-git > > > Description > ------- > > HIVE-16164 introduced a mechanism to pass HMS notification events ID to the > post-commit listeners for all DDL operations, but it didn't add it to the > ALTER TABLE event. This patch in review adds the same behavior for ALTER > TABLE events. > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > 5459554fec911b253583df1f528e5abf134f055b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > ed1b8c5cc2a4cb974dd37419c6b5f0601a035232 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 8539fea42fa2743381833ab3137579caeac64672 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IHMSHandler.java > f59f40bc33367cff7a8d0d24d0e200b16c2c30e5 > > > Diff: https://reviews.apache.org/r/65985/diff/3/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Sergio Pena > >
