----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66571/#review201038 -----------------------------------------------------------
metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql Line 1079 (original), 1079 (patched) <https://reviews.apache.org/r/66571/#comment281965> some use cases of sys is quoted while others are not ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentGroups.java Lines 38 (patched) <https://reviews.apache.org/r/66571/#comment281967> I think something on lines of following better describes it - "Returns all groups the current user belongs to" standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 6066 (patched) <https://reviews.apache.org/r/66571/#comment281983> This revokes all privileges for the db/table, not just the ones in revokePrivileges call. In that case, I am wondering if it should be passed list<HiveObjectRef> instead of PrivilegeBag ? That would make it more clear about the purpose. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 6108 (patched) <https://reviews.apache.org/r/66571/#comment281981> can you add a comment for this block (ie optimization done in that) ? - Thejas Nair On April 11, 2018, 10:33 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66571/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 10:33 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > See HIVE-19161 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0627c35 > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 801de7a > itests/hive-unit/pom.xml f473d25 > > itests/hive-unit/src/test/java/org/apache/hive/service/server/TestInformationSchemaWithPrivilege.java > PRE-CREATION > metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 3444439 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d59bf1f > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveResourceACLs.java > 53e221f > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6003ced > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentGroups.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java > PRE-CREATION > service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5c > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 450da4f > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > ebbf465 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > b2c40c2 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 2056930 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > f6c46ee > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > c47856d > standalone-metastore/src/main/thrift/hive_metastore.thrift 7450439 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 304f567 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 85c6727 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > 7d37262 > > > Diff: https://reviews.apache.org/r/66571/diff/1/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
