----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66571/#review202148 -----------------------------------------------------------
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcStorageHandler.java Lines 146 (patched) <https://reviews.apache.org/r/66571/#comment283779> indentation seems off here. ql/src/java/org/apache/hadoop/hive/ql/metadata/JarUtils.java Lines 55 (patched) <https://reviews.apache.org/r/66571/#comment283780> the accumulo specific reference shold be removed from this class ql/src/java/org/apache/hadoop/hive/ql/metadata/JarUtils.java Lines 143 (patched) <https://reviews.apache.org/r/66571/#comment283781> how about using java8 style and skip finally block - try (ZipFile zip = new ZipFile(jar)) { } - Thejas Nair On April 28, 2018, 1:09 a.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66571/ > ----------------------------------------------------------- > > (Updated April 28, 2018, 1:09 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > See HIVE-19161 > > > Diffs > ----- > > > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/HiveAccumuloHelper.java > 9fccb49 > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java > 3a2facf > > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/CompositeAccumuloRowIdFactory.java > d8b9aa3 > > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/DefaultAccumuloRowIdFactory.java > bae2930 > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f40c606 > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 8ecbaad > itests/hive-unit/pom.xml 3ae7f2f > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestRestrictedList.java > 79fdb68 > > itests/hive-unit/src/test/java/org/apache/hive/service/server/TestInformationSchemaWithPrivilege.java > PRE-CREATION > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcStorageHandler.java > df55272 > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/DatabaseAccessorFactory.java > 6d3c8d9 > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java > 772bc5d > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java > 638e2b0 > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/MsSqlDatabaseAccessor.java > PRE-CREATION > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/OracleDatabaseAccessor.java > PRE-CREATION > > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/PostgresDatabaseAccessor.java > PRE-CREATION > metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 3444439 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d59bf1f > ql/src/java/org/apache/hadoop/hive/ql/metadata/JarUtils.java PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProvider.java > 60d9dc1 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveResourceACLsImpl.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 60b63d4 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentGroups.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java > PRE-CREATION > ql/src/test/results/clientpositive/llap/resourceplan.q.out 9850276 > ql/src/test/results/clientpositive/show_functions.q.out 4df555b > service/src/java/org/apache/hive/service/server/HiveServer2.java e373628 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 397a081 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 1c8d223 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > aee416d > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 184ecb6 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > 2c9f2e5 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 92d000b > standalone-metastore/src/main/thrift/hive_metastore.thrift c56a4f9 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > defc68f > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 20c5d8a > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > bf87cfc > > > Diff: https://reviews.apache.org/r/66571/diff/6/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
