> On April 20, 2018, 4:34 p.m., Sahil Takiar wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > > Line 711 (original), 711 (patched) > > <https://reviews.apache.org/r/66290/diff/2/?file=2005792#file2005792line711> > > > > why change the method call? don't both methods return the same thing? > > > > also its more like `numModifiedRows`, right?
Changed numRows to numModifiedRows. The return value from the method waitForOperationToComplete() was never used here. This method gets called once from execute(), and the boolean isOperationComplete will already be set to true. Hence, when we call this method again, it returns the TGetOperationStatusResp as null. So I think using the alternate method suffices the requirement here. > On April 20, 2018, 4:34 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > > Lines 431 (patched) > > <https://reviews.apache.org/r/66290/diff/2/?file=2005797#file2005797line431> > > > > When you look at the counters in the log, is there anything like > > `RECORDS_OUT_[table-name]` do we know how that gets populated? I am populating the value for the counter I defined in the same way as the above mentioned counter is populated. I agree that it is like a duplicate for this counter. But to get the value of the RECORDS_OUT_{ID}_{table_name} counter, I need to get the destTableId and tableName as present in the FileSinkOperator. I could not find any straight-forward way to get these values. Hence, I thought of creating a counter with fixed name so that it can be used from places outside the Operator context. - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review201637 ----------------------------------------------------------- On April 18, 2018, 11:53 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66290/ > ----------------------------------------------------------- > > (Updated April 18, 2018, 11:53 p.m.) > > > Review request for hive, Sahil Takiar and Vihang Karajgaonkar. > > > Bugs: HIVE-14388 > https://issues.apache.org/jira/browse/HIVE-14388 > > > Repository: hive-git > > > Description > ------- > > Currently, when you run insert command on beeline, it returns a message > saying "No rows affected .." > A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)" > > Added the numRows parameter as part of QueryState. > Adding the numRows to the response as well to display in beeline. > > Getting the count in FileSinkOperator and setting it in statsMap, when it > operates only on table specific rows for the particular operation. (so that > we can get only the insert to table count and avoid counting non-table > specific file-sink operations happening during query execution). > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > 06542cee02e5dc4696f2621bb45cc4f24c67dfda > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > a88453c97835db847d74b4b4c3ef318d4d6c0ce5 > ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java > cf9c2273159c0d779ea90ad029613678fb0967a6 > ql/src/java/org/apache/hadoop/hive/ql/QueryState.java > 706c9ffa48b9c3b4a6fdaae78bab1d39c3d0efda > ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java > c084fa054cb771bfdb033d244935713e3c7eb874 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > fcdc9967f12a454a9d3f31031e2261f264479118 > service-rpc/if/TCLIService.thrift 30f8af7f3e6e0598b410498782900ac27971aef0 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h > 4321ad6d3c966d30f7a69552f91804cf2f1ba6c4 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp > b2b62c71492b844f4439367364c5c81aa62f3908 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java > 15e8220eb3eb12b72c7b64029410dced33bc0d72 > service-rpc/src/gen/thrift/gen-php/Types.php > abb7c1ff3a2c8b72dc97689758266b675880e32b > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py > 0f8fd0745be0f4ed9e96b7bbe0f092d03649bcdf > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb > 60183dae9e9927bd09a9676e49eeb4aea2401737 > service/src/java/org/apache/hive/service/cli/CLIService.java > c9914ba9bf8653cbcbca7d6612e98a64058c0fcc > service/src/java/org/apache/hive/service/cli/OperationStatus.java > 52cc3ae4f26b990b3e4edb52d9de85b3cc25f269 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 3706c72abc77ac8bd77947cc1c5d084ddf965e9f > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > c64c99120ad21ee98af81ec6659a2722e3e1d1c7 > > > Diff: https://reviews.apache.org/r/66290/diff/2/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
