> On May 8, 2018, 10:42 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > > Lines 430-439 (patched) > > <https://reviews.apache.org/r/66290/diff/5-6/?file=2014506#file2014506line437> > > > > Why did you moved this inside the if statement?
Moved this inside to not have null pointer exceptions. Noticed in some tests that sessionstate could be null. Also added the null check for the counter along with that. - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202625 ----------------------------------------------------------- On May 7, 2018, 5:58 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66290/ > ----------------------------------------------------------- > > (Updated May 7, 2018, 5:58 p.m.) > > > Review request for hive, Sahil Takiar and Vihang Karajgaonkar. > > > Bugs: HIVE-14388 > https://issues.apache.org/jira/browse/HIVE-14388 > > > Repository: hive-git > > > Description > ------- > > Currently, when you run insert command on beeline, it returns a message > saying "No rows affected .." > A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)" > > Added the numRows parameter as part of QueryState. > Adding the numRows to the response as well to display in beeline. > > Getting the count in FileSinkOperator and setting it in statsMap, when it > operates only on table specific rows for the particular operation. (so that > we can get only the insert to table count and avoid counting non-table > specific file-sink operations happening during query execution). > > > Diffs > ----- > > beeline/src/main/resources/BeeLine.properties > c41b3ed637e04d8d2d9800ad5e9284264f7e4055 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > b217259553be472863cd33bb2259aa700e6c3528 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > 06542cee02e5dc4696f2621bb45cc4f24c67dfda > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > 9f4e6f2e53b43839fefe1d2522a75a95d393544f > ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java > cf9c2273159c0d779ea90ad029613678fb0967a6 > ql/src/java/org/apache/hadoop/hive/ql/QueryState.java > 706c9ffa48b9c3b4a6fdaae78bab1d39c3d0efda > ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java > 01a5b4c9c328cb034a613a1539cea2584e122fb4 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > fcdc9967f12a454a9d3f31031e2261f264479118 > ql/src/test/results/clientpositive/llap/dp_counter_mm.q.out > 18f4c69a191bde3cae2d5efac5ef20fd0b1a9f0c > ql/src/test/results/clientpositive/llap/dp_counter_non_mm.q.out > 28f376f8c4c2151383286e754447d1349050ef4e > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out > 96819f4e1c446f6de423f99c7697d548ff5dbe06 > ql/src/test/results/clientpositive/llap/tez_input_counters.q.out > d2fcdaa1bfba03e1f0e4191c8d056b05f334443d > service-rpc/if/TCLIService.thrift 30f8af7f3e6e0598b410498782900ac27971aef0 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h > 4321ad6d3c966d30f7a69552f91804cf2f1ba6c4 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp > b2b62c71492b844f4439367364c5c81aa62f3908 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java > 15e8220eb3eb12b72c7b64029410dced33bc0d72 > service-rpc/src/gen/thrift/gen-php/Types.php > abb7c1ff3a2c8b72dc97689758266b675880e32b > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py > 0f8fd0745be0f4ed9e96b7bbe0f092d03649bcdf > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb > 60183dae9e9927bd09a9676e49eeb4aea2401737 > service/src/java/org/apache/hive/service/cli/CLIService.java > c9914ba9bf8653cbcbca7d6612e98a64058c0fcc > service/src/java/org/apache/hive/service/cli/OperationStatus.java > 52cc3ae4f26b990b3e4edb52d9de85b3cc25f269 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 3706c72abc77ac8bd77947cc1c5d084ddf965e9f > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > c64c99120ad21ee98af81ec6659a2722e3e1d1c7 > > > Diff: https://reviews.apache.org/r/66290/diff/6/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
