----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203640 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java Lines 27 (patched) <https://reviews.apache.org/r/67263/#comment285929> Using an empty String as last argument, because the standard InplaceUpdate header expects one more argument. Same in rows() method too. Should I instead pass the headerFormat and rowFormat also as a parameter, by adding methods in ProgressMonitor interface? Then I will need to update Tez code, thrift code to have response in this form. Can avoid that if this is acceptable. ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java Lines 77 (patched) <https://reviews.apache.org/r/67263/#comment285930> These states are not used as of now, but I guess it will be needed when we add progress bar in beeline. (with states similar to TezProgressMonitorStatusMapper). Are these executionStatuses good enough. ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java Lines 102 (patched) <https://reviews.apache.org/r/67263/#comment285928> Using just an int counter here, instead of adding completed stages to a HashSet as done in existing implementation, because we just need the count. - Bharathkrishna Guruvayoor Murali On May 23, 2018, 5:32 a.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67263/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 5:32 a.m.) > > > Review request for hive, Sahil Takiar and Vihang Karajgaonkar. > > > Bugs: HIVE-19602 > https://issues.apache.org/jira/browse/HIVE-19602 > > > Repository: hive-git > > > Description > ------- > > Refactor inplace progress code in Hive-on-spark progress monitor to use > ProgressMonitor instance > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 7afd8864075aa0d9708274eea8839c662324c732 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67263/diff/1/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
