> On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > > Line 70 (original), 67 (patched) > > <https://reviews.apache.org/r/67263/diff/1/?file=2027540#file2027540line72> > > > > is this still used? > > Bharathkrishna Guruvayoor Murali wrote: > Will remove this if we do not need to pass the headers , footers etc.. to > ProgressMonitor. > (ie. if the progress bar format shown in below comment is acceptable). > > Sahil Takiar wrote: > So what changes about the progress bar format if you do pass the headers > and footers?
Nothing changes, except the bit of dashed lines at the end (----), which we are considering fine for now as mentioned in below comment. So removing this variable definition. > On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > > Line 304 (original), 231 (patched) > > <https://reviews.apache.org/r/67263/diff/1/?file=2027540#file2027540line306> > > > > whats the point of this class? > > Bharathkrishna Guruvayoor Murali wrote: > I used this class to follow same pattern as in tez. I will add the logic > similar to RenderStrategy used in tez while adding beeline progress bar, so > this should be useful. > > Sahil Takiar wrote: > Ok, can this be a private class? Is it used outside `SparkJobMonitor`? Not used outside SparkJobMonitor. Making private - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203891 ----------------------------------------------------------- On May 29, 2018, 10:53 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67263/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 10:53 p.m.) > > > Review request for hive, Sahil Takiar and Vihang Karajgaonkar. > > > Bugs: HIVE-19602 > https://issues.apache.org/jira/browse/HIVE-19602 > > > Repository: hive-git > > > Description > ------- > > Refactor inplace progress code in Hive-on-spark progress monitor to use > ProgressMonitor instance > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 7afd8864075aa0d9708274eea8839c662324c732 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67263/diff/2/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
