----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66370/#review208367 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 528 (patched) <https://reviews.apache.org/r/66370/#comment292253> Why should missing stats cause AST to reanalyze? This doesn't look correct. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 539 (patched) <https://reviews.apache.org/r/66370/#comment292254> Same as above. This doesn't look correct. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 544 (patched) <https://reviews.apache.org/r/66370/#comment292255> So basically if CBO fails due to some reason beside unsupported feature we will end up throwing semantic exception. This will cause the code to not try non-cbo in case of cbo failure. I don't think we want to do that. - Vineet Garg On July 1, 2018, 8:55 a.m., Igor Kryvenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66370/ > ----------------------------------------------------------- > > (Updated July 1, 2018, 8:55 a.m.) > > > Review request for hive, Ashutosh Chauhan and Vineet Garg. > > > Bugs: HIVE-18725 > https://issues.apache.org/jira/browse/HIVE-18725 > > > Repository: hive-git > > > Description > ------- > > If there is a column reference within subquery which doesn't exist Hive > throws misleading error message. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSubquerySemanticException.java > 4321a5c789 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteViewSemanticException.java > c2a4e94a03 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e091f38bc6 > ql/src/test/queries/clientnegative/subquery_non_exisiting_column.q > PRE-CREATION > ql/src/test/results/clientnegative/subquery_non_exisiting_column.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66370/diff/5/ > > > Testing > ------- > > > Thanks, > > Igor Kryvenko > >
