> On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 913 (patched) > > <https://reviews.apache.org/r/68827/diff/1/?file=2091788#file2091788line913> > > > > Good doumentation! > > Are you 100% sure that this Map is never sused by anyone else? What > > about future code?
By future code, do you mean for someone who might use this in future? Currently, I have added a note in CreateTableObjJson to warn that the Map could be filtered based on regexes provided. > On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 917 (patched) > > <https://reviews.apache.org/r/68827/diff/1/?file=2091788#file2091788line917> > > > > make private I thought this could be used separately as a utility method, if the user has just one predicate. Should I just keep the other method which accepts a list of predicates and make this one private? - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209031 ----------------------------------------------------------- On Sept. 28, 2018, 9:38 a.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68827/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2018, 9:38 a.m.) > > > Review request for hive and Alexander Kolbasov. > > > Bugs: HIVE-20545 > https://issues.apache.org/jira/browse/HIVE-20545 > > > Repository: hive-git > > > Description > ------- > > Clients can add large-sized parameters in Table/Partition objects. So we need > to enable adding regex patterns through HiveConf to match parameters to be > filtered from table and partition objects before serialization in HMS > notifications. > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 30ea7f8129 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > c681a87a1c > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > 2668b05320 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68827/diff/1/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
