> On Sept. 26, 2018, 11:20 p.m., Alexander Kolbasov wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java > > Lines 44 (patched) > > <https://reviews.apache.org/r/68827/diff/1/?file=2091790#file2091790line44> > > > > It would be better to use hamcrest asserts and just check that you map > > matches your expected map with a single assert.
Fixed. - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209055 ----------------------------------------------------------- On Sept. 28, 2018, 9:38 a.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68827/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2018, 9:38 a.m.) > > > Review request for hive and Alexander Kolbasov. > > > Bugs: HIVE-20545 > https://issues.apache.org/jira/browse/HIVE-20545 > > > Repository: hive-git > > > Description > ------- > > Clients can add large-sized parameters in Table/Partition objects. So we need > to enable adding regex patterns through HiveConf to match parameters to be > filtered from table and partition objects before serialization in HMS > notifications. > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 30ea7f8129 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > c681a87a1c > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > 2668b05320 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68827/diff/1/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
