> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote: > >
I will take a look at the q files today, there were several plans that I did not have time to check. > On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java > > Lines 288 (patched) > > <https://reviews.apache.org/r/68868/diff/1/?file=2092504#file2092504line288> > > > > We may have Volcano node too, we need to include it. > > Vineet Garg wrote: > How do I include volcano nodes? Can you point me to an example? Tried > searching for it but couldn't figure out. The volcano nodes are RelSubset. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68868/#review209136 ----------------------------------------------------------- On Oct. 3, 2018, 12:44 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68868/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2018, 12:44 a.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-17043 > https://issues.apache.org/jira/browse/HIVE-17043 > > > Repository: hive-git > > > Description > ------- > > This patch implements/test the following optimizations > * Removal of group by on primary keys > * Reduction of group by keys on primary keys > * is NOT NULL filter removal if NOT NULL constraint is defined > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties fdd8ecc77c > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java > 635d27e723 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java > 42e60de6a8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java > f43ef01293 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java > 5857f730a8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdColumnUniqueness.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java > 1ca1937ed9 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java > 3bf62c535c > ql/src/test/queries/clientpositive/constraints_optimization.q PRE-CREATION > ql/src/test/results/clientpositive/llap/constraints_optimization.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68868/diff/2/ > > > Testing > ------- > > > Thanks, > > Vineet Garg > >
