----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69018/ -----------------------------------------------------------
Review request for hive, Ashutosh Chauhan, Gopal V, and Vineet Garg. Bugs: HIVE-20735 https://issues.apache.org/jira/browse/HIVE-20735 Repository: hive-git Description ------- As part of the review comments we agreed to: remove start and end offsets columns remove the best effort mode make the 2pc as default protocol for EOS Also this patch will include an additional enhancement to add kerberos support. Diffs ----- kafka-handler/README.md 706c77ae25 kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaOutputFormat.java 950f7315c2 kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaRecordReader.java 746de61273 kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaSerDe.java 51cfa24929 kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaStorageHandler.java 0d64cd9c9c kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaTableProperties.java 2e1f6faf1f kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java 6ae9c8d276 kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaWritable.java 681b666fdf kafka-handler/src/java/org/apache/hadoop/hive/kafka/MetadataColumn.java 60e1aea55d kafka-handler/src/java/org/apache/hadoop/hive/kafka/SimpleKafkaWriter.java c95bdb02de kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaRecordIteratorTest.java 3d3f598bc0 kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaUtilsTest.java 8aebb9254e kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaWritableTest.java 45bf7912c4 kafka-handler/src/test/org/apache/hadoop/hive/kafka/SimpleKafkaWriterTest.java d8168e02a0 ql/src/test/queries/clientpositive/kafka_storage_handler.q 595f0320b6 ql/src/test/results/clientpositive/druid/kafka_storage_handler.q.out 73f0f293d9 Diff: https://reviews.apache.org/r/69018/diff/1/ Testing ------- Thanks, Slim Bouguerra