> On Oct. 15, 2018, 12:47 a.m., Ashutosh Chauhan wrote: > > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaOutputFormat.java > > Line 52 (original), 52 (patched) > > <https://reviews.apache.org/r/69018/diff/1/?file=2097817#file2097817line52> > > > > This boolean is not used anywhere, can be removed alongwith associated > > property. > > Slim Bouguerra wrote: > As of now i have kept the path for task level commit, as a hidden > feature, that maybe we want to bring it in the future. > What you think?
Ok, we can keep it as an undocumented feature. > On Oct. 15, 2018, 12:47 a.m., Ashutosh Chauhan wrote: > > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java > > Lines 284 (patched) > > <https://reviews.apache.org/r/69018/diff/1/?file=2097822#file2097822line286> > > > > Its better to use a single principal (and its keytab) to avoid > > dependency on both. Is that not possible? If not add comments. > > Slim Bouguerra wrote: > we do not depend on both, but in case HS2 credentienals not present will > use the LLAP ones. I am not sure how ambari drop and distribute the keys, it > is safer to have this check. > I have added the comment already. >From purist point of view, Its hard to reason about which principal this logic >needs precisely because we don't know which one will be used. In practice, >however since we never usually make a distinction between llap and HS2 >principal this won't be an issue. So, we can keep this for now. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69018/#review209529 ----------------------------------------------------------- On Oct. 15, 2018, 12:07 a.m., Slim Bouguerra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69018/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2018, 12:07 a.m.) > > > Review request for hive, Ashutosh Chauhan, Gopal V, and Vineet Garg. > > > Bugs: HIVE-20735 > https://issues.apache.org/jira/browse/HIVE-20735 > > > Repository: hive-git > > > Description > ------- > > As part of the review comments we agreed to: > > remove start and end offsets columns > remove the best effort mode > make the 2pc as default protocol for EOS > Also this patch will include an additional enhancement to add kerberos > support. > > > Diffs > ----- > > kafka-handler/README.md 706c77ae25 > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaOutputFormat.java > 950f7315c2 > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaRecordReader.java > 746de61273 > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaSerDe.java > 51cfa24929 > > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaStorageHandler.java > 0d64cd9c9c > > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaTableProperties.java > 2e1f6faf1f > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java > 6ae9c8d276 > kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaWritable.java > 681b666fdf > kafka-handler/src/java/org/apache/hadoop/hive/kafka/MetadataColumn.java > 60e1aea55d > kafka-handler/src/java/org/apache/hadoop/hive/kafka/SimpleKafkaWriter.java > c95bdb02de > > kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaRecordIteratorTest.java > 3d3f598bc0 > kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaUtilsTest.java > 8aebb9254e > kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaWritableTest.java > 45bf7912c4 > > kafka-handler/src/test/org/apache/hadoop/hive/kafka/SimpleKafkaWriterTest.java > d8168e02a0 > ql/src/test/queries/clientpositive/kafka_storage_handler.q 595f0320b6 > ql/src/test/results/clientpositive/druid/kafka_storage_handler.q.out > 73f0f293d9 > > > Diff: https://reviews.apache.org/r/69018/diff/1/ > > > Testing > ------- > > > Thanks, > > Slim Bouguerra > >
