----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69512/#review211064 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java Lines 287 (patched) <https://reviews.apache.org/r/69512/#comment295919> Modulo any semijoin branches or semijoin branch going from one TS to another TS which is under consideration for merge? ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java Lines 313 (patched) <https://reviews.apache.org/r/69512/#comment295920> This extended check wasn't there earlier, do we need it now? ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java Lines 944 (patched) <https://reviews.apache.org/r/69512/#comment295935> Don't we need to check the source and target of SJ is same table on different TSs? - Ashutosh Chauhan On Dec. 5, 2018, 6:39 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69512/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2018, 6:39 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-21006 > https://issues.apache.org/jira/browse/HIVE-21006 > > > Repository: hive-git > > > Description > ------- > > HIVE-21006 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > c2456714c2693066dffc50319c3aaa1f4760ade5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java > 0cb3b21fd81ec8c86127c2eaeb9f5e5d23291455 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java > dd1d6a1924f0894e1f24c1eab6655ed3264025fc > > > Diff: https://reviews.apache.org/r/69512/diff/1/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
