> On Dec. 6, 2018, 12:10 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java > > Lines 313 (patched) > > <https://reviews.apache.org/r/69512/diff/1/?file=2112217#file2112217line313> > > > > This extended check wasn't there earlier, do we need it now?
This one was there before, but it was embedded into areMergeable. I separated it so areMergeable can be used in the other branch of the if-else clause. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69512/#review211064 ----------------------------------------------------------- On Dec. 5, 2018, 6:39 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69512/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2018, 6:39 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-21006 > https://issues.apache.org/jira/browse/HIVE-21006 > > > Repository: hive-git > > > Description > ------- > > HIVE-21006 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > c2456714c2693066dffc50319c3aaa1f4760ade5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java > 0cb3b21fd81ec8c86127c2eaeb9f5e5d23291455 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java > dd1d6a1924f0894e1f24c1eab6655ed3264025fc > > > Diff: https://reviews.apache.org/r/69512/diff/1/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
