----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/#review211612 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Line 4551 (original), 4554 (patched) <https://reviews.apache.org/r/69642/#comment296966> Changed it to NoSuchObjectException. I don't recall why I changed it to a MetaException, but it doesn't need to change. Regarding the API change, I thought about it more and changed code to not actually change any semantics. With the new change, we'll throw a NoSuchObjectException here which will get wrapped into a RuntimeException to be thrown. This will be called when the pre-event listener is fired. At that point, we can catch the RuntimeException, and rethrow the NoSuchObjectException (as it was doing before this change). - Karthik Manamcheri On Jan. 2, 2019, 8:15 p.m., Karthik Manamcheri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69642/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2019, 8:15 p.m.) > > > Review request for hive, Adam Holley, Na Li, Morio Ramdenbourg, Naveen > Gangam, Peter Vary, Sergio Pena, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve > get_partition performance > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > a9398ae1e7 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/PreReadTableEvent.java > beec72bc12 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/ThrowingSupplier.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > fe64a91b56 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/events/TestPreReadTableEvent.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69642/diff/2/ > > > Testing > ------- > > Unit tests. > Manual performance test with Cloudera BDR to notice improved backup > performance. > > > Thanks, > > Karthik Manamcheri > >
