----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/#review211643 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 4549-4555 (original), 4560-4569 (patched) <https://reviews.apache.org/r/69642/#comment297044> Isn't simpler to have a constructor that accepts the (catName, dbName, tblName, this) instead of using a Supplier? It will reduce code and make the code more readable. - Sergio Pena On Jan. 3, 2019, 1:40 a.m., Karthik Manamcheri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69642/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2019, 1:40 a.m.) > > > Review request for hive, Adam Holley, Na Li, Morio Ramdenbourg, Naveen > Gangam, Peter Vary, Sergio Pena, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve > get_partition performance > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > a9398ae1e7 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/PreReadTableEvent.java > beec72bc12 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/ThrowingSupplier.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 7429d18226 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > fe64a91b56 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > 4d7f7c1220 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > a338bd4032 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/events/TestPreReadTableEvent.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69642/diff/4/ > > > Testing > ------- > > Unit tests. > Manual performance test with Cloudera BDR to notice improved backup > performance. > > > Thanks, > > Karthik Manamcheri > >
