kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r260256192
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java
##########
@@ -266,16 +271,15 @@ private boolean shouldReplayEvent(FileStatus dir,
DumpType dumpType, String dbNa
return updateReplIdTxnTask;
}
- private Task<? extends Serializable> tableUpdateReplStateTask(String dbName,
String tableName,
- Map<String, String>
partSpec, String replState,
- Task<? extends
Serializable> preCursor) throws SemanticException {
+ private Task<? extends Serializable> tableUpdateReplStateTask(TableName
tableName, Map<String, String> partSpec,
Review comment:
now that I see this...I think that it would probably make sense to also
include `partSpec` into this object
(`PartishRef`: `catalog,database,tablename,partitonspec` ) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
