kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a database object reference class URL: https://github.com/apache/hive/pull/550#discussion_r260254184
########## File path: ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java ########## @@ -651,7 +652,7 @@ public void notifyTableChanged(String dbName, String tableName, long updateTime) List<CacheEntry> entriesToInvalidate = null; rwLock.writeLock().lock(); try { - String key = (dbName.toLowerCase() + "." + tableName.toLowerCase()); + String key = TableName.getDbTable(dbName, tableName).toLowerCase(); Review comment: I would think that at this point we should already have a tablename from somewhere; constructing it here doesn't really make sense ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services