----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71458/#review217689 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java Line 275 (original), 276 (patched) <https://reviews.apache.org/r/71458/#comment304999> L276 and L277 (in patched version) should be out of _if_ _estimateStats_ block, since we want to obtain better data size from column stats, independently on whether we estimate them or not. - Jesús Camacho Rodríguez On Sept. 11, 2019, 9:18 a.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71458/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2019, 9:18 a.m.) > > > Review request for hive, Gopal V, Jesús Camacho Rodríguez, Zoltan Haindrich, > and Vineet Garg. > > > Bugs: HIVE-22163 > https://issues.apache.org/jira/browse/HIVE-22163 > > > Repository: hive-git > > > Description > ------- > > CBO: Enabling CBO turns on stats estimation, even when the estimation is > disabled > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 8d9718f2c8 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 1795ae5626 > ql/src/test/queries/clientpositive/cbo_stats_estimation.q PRE-CREATION > ql/src/test/results/clientpositive/cbo_stats_estimation.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/join_reordering_no_stats.q.out > fddffbb0a8 > > > Diff: https://reviews.apache.org/r/71458/diff/2/ > > > Testing > ------- > > New qtest: cbo_stats_estimation.q > > > Thanks, > > Krisztian Kasa > >
