----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71561/ -----------------------------------------------------------
Review request for hive, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet Garg. Bugs: HIVE-22250 https://issues.apache.org/jira/browse/HIVE-22250 Repository: hive-git Description ------- Describe function does not provide description for rank functions ================================================================= The `DESCRIBE FUNCTION` command gets the description of a function from the `@Description` annotations `value` field. If an UDF is annotated with the `@WindowFunctionDescription` hive prints ``` There is no documentation for function <function> ``` Even if the description is present in the `@WindowFunctionDescription` annotation. This patch implements a fall back to get the description text from `@WindowFunctionDescription` if `@Description` annotation does not exists. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/ddl/function/desc/DescFunctionOperation.java 6a94a93ef9 ql/src/test/queries/clientpositive/desc_function.q d055d9ca03 ql/src/test/results/clientpositive/desc_function.q.out 1f804bba60 Diff: https://reviews.apache.org/r/71561/diff/1/ Testing ------- Added test cases to `desc_function.q`: ``` DESCRIBE FUNCTION dense_rank; DESCRIBE FUNCTION EXTENDED dense_rank; ``` Thanks, Krisztian Kasa