----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71561/#review218039 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java Lines 171 (patched) <https://reviews.apache.org/r/71561/#comment305540> This seems to be rather strict. I think we may call this method when a user includes its own UDF? Mainly, I am concerned with custom UDFs that will stop working if they do not include a description. Probably a WARN log message is more adequate. - Jesús Camacho Rodríguez On Oct. 2, 2019, 2:52 p.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71561/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2019, 2:52 p.m.) > > > Review request for hive, Jesús Camacho Rodríguez, Zoltan Haindrich, and > Vineet Garg. > > > Bugs: HIVE-22250 > https://issues.apache.org/jira/browse/HIVE-22250 > > > Repository: hive-git > > > Description > ------- > > Describe function does not provide description for rank functions > ================================================================= > The `DESCRIBE FUNCTION` command gets the description of a function from the > `@Description` annotations `value` field. If an UDF is annotated with the > `@WindowFunctionDescription` hive prints > ``` > There is no documentation for function <function> > ``` > Even if the description is present in the `@WindowFunctionDescription` > annotation. > > This patch moves the `@WindowFunctionDescription.Description` field to a > separate annotation and provide the `@Description` annotation if both > annotations are missing. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java fc2a0e1970 > ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionDescription.java > 511d9641c3 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java a7f4bf1fcc > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 8f4ec3b1ef > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 7a0145243d > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 451b45fbbc > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 4fe9c323cc > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java b31eeb08a0 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 315789c1c1 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBloomFilter.java > a8bcc972bb > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCumeDist.java > 70541fe565 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFDenseRank.java > 30bfd2bb8c > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFFirstValue.java > b8b7d8e6da > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLag.java > e0edbb42af > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLastValue.java > dadec3b793 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLead.java > e678278b8b > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFNTile.java > 8b2812d5bc > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentRank.java > 1a7c94431b > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileCont.java > e7e4fda6ea > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileDisc.java > d7c295cb11 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFRank.java > a28def73a1 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFRowNumber.java > 41a3e582ec > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrueOOM.java > c5c73835af > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBucketNumber.java > 472cc85047 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEpochMilli.java > d8e822ae97 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInBloomFilter.java > 733fe63e80 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSurrogateKey.java > 1372b60724 > ql/src/test/queries/clientpositive/desc_function.q d055d9ca03 > ql/src/test/results/clientpositive/desc_function.q.out 1f804bba60 > > > Diff: https://reviews.apache.org/r/71561/diff/2/ > > > Testing > ------- > > Added test cases to `desc_function.q`: > ``` > DESCRIBE FUNCTION dense_rank; > DESCRIBE FUNCTION EXTENDED dense_rank; > ``` > > > Thanks, > > Krisztian Kasa > >
