----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71671/#review218420 -----------------------------------------------------------
Thanks for the patch. A nit and a question. ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java Line 239 (original), 220 (patched) <https://reviews.apache.org/r/71671/#comment306127> Could we remove the extra spaces if we are here, please? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java Lines 85-87 (patched) <https://reviews.apache.org/r/71671/#comment306128> Maybe this should be checked outside? This is something general? Or am I mistaken? - Peter Vary On okt. 24, 2019, 3:57 du, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71671/ > ----------------------------------------------------------- > > (Updated okt. 24, 2019, 3:57 du) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-22401: Refactor CompactorMR > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 0f1579aa542f83b68f2efc92e08e6c0a32bd113d > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71671/diff/3/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
