> On Oct. 28, 2019, 5:44 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java > > Lines 85-87 (patched) > > <https://reviews.apache.org/r/71671/diff/3/?file=2170351#file2170351line85> > > > > Maybe this should be checked outside? This is something general? Or am > > I mistaken?
In my next change, related to query based minor compaction, I will refactor this part as well. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71671/#review218420 ----------------------------------------------------------- On Oct. 24, 2019, 3:57 p.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71671/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2019, 3:57 p.m.) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-22401: Refactor CompactorMR > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 0f1579aa542f83b68f2efc92e08e6c0a32bd113d > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71671/diff/3/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
