----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/ -----------------------------------------------------------
Review request for hive and Zoltan Haindrich. Bugs: HIVE-22526 https://issues.apache.org/jira/browse/HIVE-22526 Repository: hive-git Description ------- The Driver class contains ~600 lines of code responsible for compiling the command. That means that from the command String a Plan needs to be created, and also a transaction needs to be started (in most of the cases). This is a thing done by the compile function, which has a lot of sub functions to help this task, while itself is also really big. All these codes should be put into a separate class, where it can do it's job without getting mixed with the other codes in the Driver. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/Compiler.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/Driver.java bb41c15bb4 ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1afcfc8969 Diff: https://reviews.apache.org/r/71811/diff/1/ Testing ------- All the tests are still running fine. Thanks, Miklos Gergely