> On Nov. 28, 2019, 12:39 p.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Compiler.java > > Lines 165 (patched) > > <https://reviews.apache.org/r/71811/diff/1/?file=2179010#file2179010line165> > > > > I think DriverState should live at the "Driver" level; and not get > > mixed into other classes (followup?)
Unfortunately the failure of some tests showed me that driverState must be in Compiler too. Compiler is a step of the driver, and during that step some state modifications are happening, thus it should be sent to the compiler to mark them. - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/#review218846 ----------------------------------------------------------- On Dec. 1, 2019, 7:12 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71811/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2019, 7:12 a.m.) > > > Review request for hive and Zoltan Haindrich. > > > Bugs: HIVE-22526 > https://issues.apache.org/jira/browse/HIVE-22526 > > > Repository: hive-git > > > Description > ------- > > The Driver class contains ~600 lines of code responsible for compiling the > command. That means that from the command String a Plan needs to be created, > and also a transaction needs to be started (in most of the cases). This is a > thing done by the compile function, which has a lot of sub functions to help > this task, while itself is also really big. All these codes should be put > into a separate class, where it can do it's job without getting mixed with > the other codes in the Driver. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Compiler.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 54d12baa96 > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1afcfc8969 > ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java 26e904af0b > ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 4d79ebc933 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java fa6c9d03ec > > > Diff: https://reviews.apache.org/r/71811/diff/4/ > > > Testing > ------- > > All the tests are still running fine. > > > Thanks, > > Miklos Gergely > >
