----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71932/#review219122 -----------------------------------------------------------
ql/src/test/queries/clientpositive/topnkey_grouping_sets.q Lines 41 (patched) <https://reviews.apache.org/r/71932/#comment307222> Can we add more examples to this q file? In particular, I was thinking about queries: - With a lower limit. - With custom nulls order spec in order by. - With order by with more than a single column and different order spec, e.g., order by a desc, b asc. - With aggregate functions, e.g., sum, min, max. - Without including all grouping sets in spec, e.g., ((a), (b)), ((a, b), ()), rollup, cube. - With more than a single group by in the query. - Jesús Camacho Rodríguez On Jan. 2, 2020, 8:02 a.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71932/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2020, 8:02 a.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-22652 > https://issues.apache.org/jira/browse/HIVE-22652 > > > Repository: hive-git > > > Description > ------- > > HIVE-22652: TopNKey push through Group by with Grouping sets > ============================================================ > Enable TNK op push down through Group by with Grouping sets by removing the > lines which checked whether the GBY operator has GROUPING SETS > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/topnkey/TopNKeyPushdownProcessor.java > c79c371a8b > ql/src/test/queries/clientpositive/topnkey_grouping_sets.q PRE-CREATION > ql/src/test/results/clientpositive/llap/topnkey_grouping_sets.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out > c7e837905d > ql/src/test/results/clientpositive/perf/tez/cbo_query14.q.out d1e8c3806e > ql/src/test/results/clientpositive/perf/tez/cbo_query77.q.out aa080603e1 > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query14.q.out > 59fcf951fe > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query77.q.out > 39da7ea903 > ql/src/test/results/clientpositive/perf/tez/constraints/query14.q.out > 65d3faa20f > ql/src/test/results/clientpositive/perf/tez/constraints/query27.q.out > e1a48eaeea > ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out > 13288d28b4 > ql/src/test/results/clientpositive/perf/tez/constraints/query77.q.out > c2758b7033 > ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out > 72a54928c2 > ql/src/test/results/clientpositive/perf/tez/query14.q.out 00bc4cb026 > ql/src/test/results/clientpositive/perf/tez/query27.q.out 774c0fd192 > ql/src/test/results/clientpositive/perf/tez/query5.q.out 03980ac2c0 > ql/src/test/results/clientpositive/perf/tez/query77.q.out fcfc5a33bc > ql/src/test/results/clientpositive/perf/tez/query80.q.out 3020b58781 > ql/src/test/results/clientpositive/topnkey_grouping_sets.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/71932/diff/4/ > > > Testing > ------- > > - New q test: topnkey_grouping_sets.q > - Run `src/test/queries/clientpositive/perf/query*.q` tests with > TestTezPerfCliDriver, TestTezPerfConstraintsCliDriver > > > Thanks, > > Krisztian Kasa > >
