-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72264/#review220086
-----------------------------------------------------------




standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Lines 2417 (patched)
<https://reviews.apache.org/r/72264/#comment308375>

    Do you think it would make sense to add "ForUpdate" into the method name? 
(i.e. getNextLockIdForUpdate)


- Denys Kuzmenko


On March 24, 2020, 2:24 p.m., Marton Bod wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72264/
> -----------------------------------------------------------
> 
> (Updated March 24, 2020, 2:24 p.m.)
> 
> 
> Review request for hive, Denys Kuzmenko and Peter Vary.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-23052: Optimize lock enqueueing in TxnHandler
> 
> 
> Diffs
> -----
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
>  06defdb910 
> 
> 
> Diff: https://reviews.apache.org/r/72264/diff/1/
> 
> 
> Testing
> -------
> 
> Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21249/
> Custom benchmark tests with local and remote DB
> 
> 
> Thanks,
> 
> Marton Bod
> 
>

Reply via email to