----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220139 -----------------------------------------------------------
LGTM, 1 small comment, for your consideration, otherwise - ship it! standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2443 (original), 2496 (patched) <https://reviews.apache.org/r/72264/#comment308464> Could we combine this block with above check? - Denys Kuzmenko On March 24, 2020, 2:24 p.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72264/ > ----------------------------------------------------------- > > (Updated March 24, 2020, 2:24 p.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23052: Optimize lock enqueueing in TxnHandler > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > f92ce7325e > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DbCPDataSourceProvider.java > 85719fdf84 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java > 76bbf3bc1e > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 74ef88545e > > > Diff: https://reviews.apache.org/r/72264/diff/2/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21249/ > Custom benchmark results attached to ticket: > https://issues.apache.org/jira/browse/HIVE-23052 > > > Thanks, > > Marton Bod > >
