----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220347 -----------------------------------------------------------
Mostly agree, few comments. I would like to ask you to go through them, and if there are any places where the problem should not happen use at least info level. Thanks, Peter standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 4492 (patched) <https://reviews.apache.org/r/72378/#comment308665> nit: Maybe remove the last ','? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4810 (original), 4800 (patched) <https://reviews.apache.org/r/72378/#comment308666> I prefer the original info level for these logs. - Peter Vary On ápr. 17, 2020, 11:30 de, Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72378/ > ----------------------------------------------------------- > > (Updated ápr. 17, 2020, 11:30 de) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23201: Improve logging in locking > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java 4b6bc3e1e3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 962a63d418 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > b3a1f826bb > > > Diff: https://reviews.apache.org/r/72378/diff/1/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21717/ > > > Thanks, > > Marton Bod > >