----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220419 -----------------------------------------------------------
Looks good, however I don't really like change with REQ_LOCKS_ALIASED_FIELDS as it generats much bigger query (keep in mind there 3 of them joined by union, will be 4 for excl_write) + we are transfering more data that we are not very interested in. To get more information about the lock we can simply run show locks. - Denys Kuzmenko On April 17, 2020, 11:30 a.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72378/ > ----------------------------------------------------------- > > (Updated April 17, 2020, 11:30 a.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23201: Improve logging in locking > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java 4b6bc3e1e3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > e7910c1c5d > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > b3a1f826bb > > > Diff: https://reviews.apache.org/r/72378/diff/3/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21717/ > > > Thanks, > > Marton Bod > >
