----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72379/#review220363 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractTestJdbcGenericUDTFGetSplits.java Lines 181 (patched) <https://reviews.apache.org/r/72379/#comment308688> Add test for limit with predicates, groupby queries as well. Also, make sure, we have partitioned table too. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java Line 240 (original), 241 (patched) <https://reviews.apache.org/r/72379/#comment308686> Do we need this computation? Can't we just use forceSingleSplit instead of generateSingleSplit? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java Line 259 (original), 260 (patched) <https://reviews.apache.org/r/72379/#comment308687> Error message to be updated for limit query too. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java Lines 344 (patched) <https://reviews.apache.org/r/72379/#comment308685> This issue should be there even for "order by" queries. How it work there? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java Lines 347 (patched) <https://reviews.apache.org/r/72379/#comment308689> Since, we always materialize the results for limit query, I think, forceSingleSplit logic is not needed. Even, if we generate multiple splits on this temp table, the eventual results will have only expected number of rows. - Sankar Hariappan On April 17, 2020, 12:28 p.m., Adesh Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72379/ > ----------------------------------------------------------- > > (Updated April 17, 2020, 12:28 p.m.) > > > Review request for hive and Sankar Hariappan. > > > Repository: hive-git > > > Description > ------- > > This issue occurs when there are multiple llap daemons running > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7b3acad511 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractTestJdbcGenericUDTFGetSplits.java > 8cbca69737 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 00a6c89b1e > > > Diff: https://reviews.apache.org/r/72379/diff/1/ > > > Testing > ------- > > Waiting for Hive QA run. > > > Thanks, > > Adesh Rao > >
