> On April 20, 2020, 2:19 a.m., Sankar Hariappan wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractTestJdbcGenericUDTFGetSplits.java > > Lines 181 (patched) > > <https://reviews.apache.org/r/72379/diff/1/?file=2223577#file2223577line181> > > > > Add test for limit with predicates, groupby queries as well. Also, make > > sure, we have partitioned table too. > > Adesh Rao wrote: > Added queries with predicates and groupby. Since the existing test suite > does not have partitioned table, need to go through other tests to figure out > the standard way to generate a partitioned table.
done. - Adesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72379/#review220363 ----------------------------------------------------------- On April 21, 2020, 11:17 a.m., Adesh Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72379/ > ----------------------------------------------------------- > > (Updated April 21, 2020, 11:17 a.m.) > > > Review request for hive and Sankar Hariappan. > > > Repository: hive-git > > > Description > ------- > > Since limit constraint was ignored while creating splits. If multiple llap > daemons execute splits, output contains more rows than specified by limit > constraint. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractTestJdbcGenericUDTFGetSplits.java > 8cbca69737 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcGenericUDTFGetSplits.java > defbe78802 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcGenericUDTFGetSplits2.java > 330174513c > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 00a6c89b1e > > > Diff: https://reviews.apache.org/r/72379/diff/3/ > > > Testing > ------- > > Waiting for Hive QA run. > > > Thanks, > > Adesh Rao > >
