----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72403/#review220506 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 4046 (patched) <https://reviews.apache.org/r/72403/#comment308971> Can we update these descriptions? These configs options now imply more than what we state here. You can copy them from Quotation.java. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java Line 282 (original), 279 (patched) <https://reviews.apache.org/r/72403/#comment308972> We should edit/delete this comment. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java Line 291 (original), 288 (patched) <https://reviews.apache.org/r/72403/#comment308973> 'NONE' will never be reached (default is before it). Additionally, should we consider using backticks here always now that we support both in the standard mode? ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java Lines 116 (patched) <https://reviews.apache.org/r/72403/#comment308974> 'STANDARD' will never be reached? It may make sense to use backticks since they are supported in STANDARD mode now. Additionally, I think we should call escape these database / table names? Can we add a q test? ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java Lines 78 (patched) <https://reviews.apache.org/r/72403/#comment308975> Probably not needed anymore to diferentiate for column and standard; backticks works for both. ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java Lines 191 (patched) <https://reviews.apache.org/r/72403/#comment308976> Do we need to escape the column name? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 15147 (patched) <https://reviews.apache.org/r/72403/#comment308977> Do we need to re-escape here? ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out Lines 1024 (patched) <https://reviews.apache.org/r/72403/#comment308978> Can we use count on top of the column for these queries in the q tests? Maybe we can even count the nulls with a case statement? I think the testing coverage will be similar but the size of these files will be more manageable. - Jesús Camacho Rodríguez On April 27, 2020, 8:22 a.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72403/ > ----------------------------------------------------------- > > (Updated April 27, 2020, 8:22 a.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-19064 > https://issues.apache.org/jira/browse/HIVE-19064 > > > Repository: hive-git > > > Description > ------- > > Add mode to support delimited identifiers enclosed within double quotation > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a97a623235 > itests/src/test/resources/testconfiguration.properties c55f8db61a > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > 1c0c62fb13 > parser/pom.xml 18e0ad801d > > parser/src/java/org/apache/hadoop/hive/ql/parse/ANTLRNoCaseStringStream.java > PRE-CREATION > parser/src/java/org/apache/hadoop/hive/ql/parse/GenericHiveLexer.java > PRE-CREATION > parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 23f74ba05e > parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexerParent.g > PRE-CREATION > parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexerStandard.g > PRE-CREATION > parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g b03b0989b8 > parser/src/java/org/apache/hadoop/hive/ql/parse/Quotation.java PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AlterViewAddPartitionAnalyzer.java > c1d2887ec8 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java > 7820013ab0 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java > 08aeeb2acd > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java 26c7a606bf > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java > 9bcc472a62 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 35f7ec674a > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 48c0a4a8ad > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 0de3730351 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 6eb1ca2645 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCastFormat.java > 81540ba8c1 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveUtils.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestReplicationSemanticAnalyzer.java > 81ab01d301 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFCastFormat.java > 9afd5af2be > ql/src/test/queries/clientnegative/database_create_invalid_name.q > 5d6749542b > ql/src/test/queries/clientpositive/quotedid_basic_standard.q PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q > 08df0d803c > ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q > PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_2.q > PRE-CREATION > ql/src/test/results/clientnegative/database_create_invalid_name.q.out > 4b2cd1e41b > > ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_1.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/quotedid_basic_standard.q.out > PRE-CREATION > ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out > b1a808a805 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > a874121e12 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 62f5773f9b > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 32494ae257 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 3f04abe47a > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > 9d7cfd2a32 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > 6d82d794ca > > > Diff: https://reviews.apache.org/r/72403/diff/5/ > > > Testing > ------- > > mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver > -Dqfile=quotedid_basic_standard.q,quote2.q,crtseltbl_serdeprops.q -pl > itests/qtest -Pitests > > mvn test -Dtest.output.overwrite -DskipSparkTests > -Dtest=TestMiniLlapLocalCliDriver > -Dqfile=special_character_in_tabnames_quotes_1.q,special_character_in_tabnames_quotes_2.q,special_character_in_tabnames_1.q,special_character_in_tabnames_2.q > -pl itests/qtest -Pitests > > > Thanks, > > Krisztian Kasa > >
