I am not against restoring itest.jdbc.jars property but for this case
I prefer the explicit declaration of the dependency.
Adding an optional or test scope dependency is much simpler and works
out of the box. We don't need to download jars manually and we don't
need to remember how the system property is called in order to run the
test.
Anyways, we all agree that we want StartMiniHS2Cluster to run on
different metastore backends so we can create a JIRA/PR and move this
forward. How we are going to do it is implementation details so we can
continue the discussion under the respective ticket.
Best,
Stamatis
On Tue, Aug 22, 2023 at 6:46 PM László Bodor <bodorlaszlo0...@gmail.com> wrote:
>
> Yeah, I think we should simply re-add the possibility to add jars to
> classpath, call it "itest.jdbc.jars" to preserve the old behavior and
> parameter name.
>
> Denys Kuzmenko <dkuzme...@apache.org> ezt írta (időpont: 2023. aug. 22., K,
> 12:43):
>
> > Instead of adding the dependencies, can't we add the possibility to
> > include jdbc jars in the classpath?
> > something like this:
> > <plugin>
> > <groupId>org.apache.maven.plugins</groupId>
> > <artifactId>maven-failsafe-plugin</artifactId>
> > <executions>
> > <execution>
> > <goals>
> > <goal>integration-test</goal>
> > <goal>verify</goal>
> > </goals>
> > </execution>
> > </executions>
> > <configuration>
> > ....
> > <additionalClasspathElements>
> >
> > <additionalClasspathElement>${itest.jdbc.jars}</additionalClasspathElement>
> > </additionalClasspathElements>
> > ...
> > </configuration>
> > </plugin>
> >
