[ 
https://issues.apache.org/jira/browse/HIVE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266922#comment-13266922
 ] 

Carl Steinbach commented on HIVE-2996:
--------------------------------------


@Namit: I'm not concerned that these hooks are going to break
anything. Actually, I have the opposite concern, namely that the
new hooks and tests are going to make it much harder for Hive
developers to improve internal, non-public APIs by locking down
internal, non-public implementation details. We already have more
than a thousand tests designed to catch changes to the public
APIs (HQL, the public listener and hook interfaces, the Thrift
APIs, etc), and HIVE-2670 is set to add better support for
running these tests in the sort of e2e scenarios that members of
the community encounter in production environments.

Since this is such a big change I propose that this work be done
on a separate branch, either here or on github, and then when
it's finished we can give the committers a chance to evaluate it
as a whole. How does that sound?
                
> minor bug in hooks (NPE)
> ------------------------
>
>                 Key: HIVE-2996
>                 URL: https://issues.apache.org/jira/browse/HIVE-2996
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Namit Jain
>         Attachments: HIVE-2996.D2991.1.patch
>
>
> NPE in AbstractSmcConfigHook.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to