[ 
https://issues.apache.org/jira/browse/HIVE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266930#comment-13266930
 ] 

Namit Jain commented on HIVE-2996:
----------------------------------

@Carl, this will be a iterative process, and the changes are only going in 
contrib.
The internal, non-public APIs are locked for facebook anyway, and we run into 
these
problems at deployment time. It would be very difficult to keep it in sync. in 
a separate 
branch.

Right now, there are no tests for these, so any change by any contributor 
cannot break anything 
in these hooks. As I will be adding tests for these hooks, I will be converting 
these hooks to 
not use any private data-structures/APIs. That is the reason, I did not blindly 
any existing tests.
In the last few pushes, we have run into random issues, which could have been 
addressed before had
this test been in place.

As I said before, the purpose of HIVE-2670 is similar, but having the facebook 
deployment in the open
makes us feel much more comfortable in running the recent branch of hive. I 
really dont want Facebook 
to have its own branch for hive, which makes it very difficult to sync. up 
later. The problem is that
if I keep developing in a separate branch, i will diverge very quickly and be 
never able to converge.
                
> minor bug in hooks (NPE)
> ------------------------
>
>                 Key: HIVE-2996
>                 URL: https://issues.apache.org/jira/browse/HIVE-2996
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Namit Jain
>         Attachments: HIVE-2996.D2991.1.patch
>
>
> NPE in AbstractSmcConfigHook.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to