----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10785/ -----------------------------------------------------------
(Updated April 25, 2013, 11:39 p.m.) Review request for hive. Changes ------- slight change to avoid conflict on file CogeGen.java due to Jitendra's previous patch. Also updates build files in this branch to avoid a windows build issue by applying patches for https://issues.apache.org/jira/browse/HIVE-4347 https://issues.apache.org/jira/browse/HIVE-4348 Description ------- Implement vectorized filters that compare a string column vector on the left and a scalar on the right. Use a template to generate code for all different comparison operators. This addresses bug HIVE-4383. https://issues.apache.org/jira/browse/HIVE-4383 Diffs (updated) ----- hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm 5940cbb hcatalog/build.xml 6f8389b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColEqualStringScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColGreaterEqualStringScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColGreaterStringScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColLessEqualStringScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColLessStringScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColNotEqualStringScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java 32c7e11 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/FilterStringColumnCompareScalar.txt PRE-CREATION Diff: https://reviews.apache.org/r/10785/diff/ Testing ------- Thanks, Eric Hanson
