----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10840/#review19883 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Chauhan On April 29, 2013, 6:53 p.m., Eric Hanson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10840/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 6:53 p.m.) > > > Review request for hive. > > > Description > ------- > > Implement vectorized string column-scalar filters. Includes changes > equivalent to HIVE-4348 to correct unit test build failure on Windows in this > branch. > > > This addresses bug HIVE-4383. > https://issues.apache.org/jira/browse/HIVE-4383 > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColEqualStringScalar.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColGreaterEqualStringScalar.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColGreaterStringScalar.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColLessEqualStringScalar.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColLessStringScalar.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColNotEqualStringScalar.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java > 318541b > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/FilterStringColumnCompareScalar.txt > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java > fe34b11 > > Diff: https://reviews.apache.org/r/10840/diff/ > > > Testing > ------- > > > Thanks, > > Eric Hanson > >